Update custom_indicators.Rmd #32
Conversation
Fixing the duplicate axis issue
vignettes/custom_indicators.Rmd
Outdated
| @@ -20,6 +20,7 @@ knitr::opts_chunk$set( | |||
|
|
|||
| ```{r setup} | |||
| library(cryptoQuotes) | |||
| library(dplyr) | |||
There was a problem hiding this comment.
It would be a shame to declare a dependency on dplyr just for this PR. I suggest that you post your PR without dplyr.
vignettes/custom_indicators.Rmd
Outdated
| @@ -39,15 +40,18 @@ We start by creating a simple `chart`-object with `volume` as it's only indicato | |||
| # 1) create a simple chart | |||
| # object | |||
| chart_object <- chart( | |||
| ticker = BTC, | |||
| ticker = BTC , | |||
There was a problem hiding this comment.
Please remove this additional white space; I spend many hours on spotting these. It triggers my OCD 🤣
vignettes/custom_indicators.Rmd
Outdated
| main = kline(), | ||
| sub = list( | ||
| volume() | ||
| ), | ||
| options = list( | ||
| dark = FALSE | ||
| ) | ||
| ) | ||
| )%>% |
There was a problem hiding this comment.
I do not use %>% at all, so please avoid using it in the vignette!
|
Hi @stavralf, Could you please add in the vignette text why you are using Or maybe it is an obvious issue that I am blind to? If so please do tell me! 😄 Update: It just occurred to me that we have two instances of charts with custom indicators. But I only see one fix in your |
* Removed `dplyr` * Removed whitespace * added namespaced qualified `layout`-call
Fixing the duplicate axis issue