Fix timer #26
Merged
Fix timer #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-orlovsky
added
bug
dr-orlovsky
force-pushed
the
timer
branch
2 times, most recently
from
124725d
to
4ce84a5
Compare
cloudhead
reviewed
Feb 13, 2024
src/timeouts.rs
Outdated
| let time = time.into(); | ||
| let last = *self.timeouts.first()?; | ||
| Some(if last >= time { | ||
| Duration::from_secs(last.as_secs() - time.as_secs()) |
There was a problem hiding this comment.
You're losing millisecond resolution by converting to seconds here.
cloudhead
approved these changes
Feb 21, 2024
|
Released as v0.5.0 CC @cloudhead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.