Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetTimer doesn't work with 0 value #25

Closed
cloudhead opened this issue Feb 9, 2024 · 3 comments
Closed

SetTimer doesn't work with 0 value #25

cloudhead opened this issue Feb 9, 2024 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@cloudhead
Copy link
Contributor

When setting a timer via Action::SetTimer, if a value of 0 is used, the timer never seems to expire.

@dr-orlovsky dr-orlovsky self-assigned this Feb 10, 2024
@dr-orlovsky dr-orlovsky added the bug Something isn't working label Feb 10, 2024
@dr-orlovsky dr-orlovsky added this to the v0.4.0 milestone Feb 10, 2024
@dr-orlovsky
Copy link
Member

dr-orlovsky commented Feb 10, 2024

The question is what the timer should do in this case...

I mean 0 means "zero nanosecs", meaning that when it reaches reactor it is already a point in the past. But I understand that from an UI perspective this is counter-intuitive and it must do ... what?

@cloudhead
Copy link
Contributor Author

It must be treated like any other duration: if the timer expired, trigger it as soon as possible.

@cloudhead
Copy link
Contributor Author

Closed in #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants