-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use allocator via init_options argument. #2129
Conversation
Signed-off-by: Tomoya Fujita <[email protected]>
@ros-pull-request-builder retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, the allocator is being used before we initialize init_options_
. Switching to the passed-in init_options
fixes it.
That said, I suggest we run CI with |
@Mergifyio backport humble |
✅ Backports have been created
|
Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 1a796b5)
@clalancette sorry i missed your comment, browser cache or something did not show it. i will start the CI as you suggested. |
all test passed but it show |
unstable failure is not related to this PR. |
Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 1a796b5) Co-authored-by: Tomoya Fujita <[email protected]>
Signed-off-by: Tomoya Fujita <[email protected]>
part of ros2/rcl#1036, but independent bug fix.