Custom logging allocator not passed to rcutils_logging_initialize_with_allocator

[jrutgeer]

Logging is initialized by a call to rcl_logging_configure_with_output_handler() (e.g. from rclcpp::init()).

This calls RCUTILS_LOGGING_AUTOINIT and then sets the logger allocator:

rcl/rcl/src/rcl/logging.c

Lines 65 to 66 in 4eccc3c

	RCUTILS_LOGGING_AUTOINIT;
	g_logging_allocator = *allocator;

I think this is a bug, as RCUTILS_LOGGING_AUTOINIT resolves to rcutils_logging_initialize() which calls rcutils_logging_initialize_with_allocator(rcutils_get_default_allocator());, i.e. with the default allocator (malloc) instead of the provided one. So the logging hash table gets the default allocator and not the provided one (and probably all other allocations as well as, since this seems the only place where g_rcutils_logging_allocator is set).

https://github.com/ros2/rcutils/blob/61018b2f88e55ac81edda4a45a02634493c999ed/include/rcutils/logging.h#L560-L572

https://github.com/ros2/rcutils/blob/61018b2f88e55ac81edda4a45a02634493c999ed/src/logging.c#L129-L132

[fujitatomoya]

@clalancette minor fixes, could you take a look at those?

• use allocator via init_options argument. rclcpp#2129 (independent bugfix, but found this during this issue.)
• add RCUTILS_LOGGING_AUTOINIT_WITH_ALLOCATOR. rcutils#415
• use user-defined allocator to configure logging. #1047 (depends on add RCUTILS_LOGGING_AUTOINIT_WITH_ALLOCATOR. rcutils#415)

[jrutgeer]

Haven't had a chance to look at it in detail, but on first sight I don't think this will fix it as each log call calls RCUTILS_LOGGING_AUTOINIT and there are log calls before rcl_logging_configure_with_output_handler()

See also #1037 (comment)

[fujitatomoya]

Ah yeah, that is true, i was focusing on rclcpp. but if application calls rcl or rcutils directly to initialize the logger, that is gonna be the problem.

See also #1037 (comment)

thanks, i will take a look at it.

[fujitatomoya]

@jrutgeer as you mentioned #1036 (comment), this is related to #1037. So i will keep that on #1037 instead, closing this issue since [Custom logging allocator not passed to rcutils_logging_initialize_with_allocator](https://github.com/ros2/rcl/issues/1036#top) is addressed.