Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate launch tests to new launch_testing features & API #318

Merged
merged 11 commits into from
Apr 30, 2019

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Mar 25, 2019

Connected to ros2/launch#208.

@hidmic hidmic added the in progress Actively being worked on (Kanban column) label Mar 25, 2019
@hidmic hidmic added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Apr 12, 2019
@hidmic hidmic force-pushed the hidmic/import_launch_testing branch from 2075775 to 3bbc34f Compare April 16, 2019 15:05
@jacobperron jacobperron self-requested a review April 25, 2019 23:20
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI.

demo_nodes_cpp/test/test_executables_tutorial.py.in Outdated Show resolved Hide resolved
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@hidmic
Copy link
Contributor Author

hidmic commented Apr 29, 2019

We'll need to revisit some of the TODOs I've left here later on. Mainly, Fast-RTPS is taking unusually long to forward a service request within the same process. Or at least it manifests itself when trying to set parameters, see here. I've patched it because it's unrelated to these changes but we shuld revisit it afterwards.

@hidmic hidmic force-pushed the hidmic/import_launch_testing branch from c230b02 to 38eb873 Compare April 29, 2019 21:27
@hidmic
Copy link
Contributor Author

hidmic commented Apr 30, 2019

Alright, CI failures are unrelated. Can I get another approval after latest changes?

@hidmic hidmic merged commit 09b6291 into master Apr 30, 2019
@delete-merged-branch delete-merged-branch bot deleted the hidmic/import_launch_testing branch April 30, 2019 22:47
@hidmic hidmic removed the in review Waiting for review (Kanban column) label Apr 30, 2019
routiful pushed a commit to ROBOTIS-move/demos that referenced this pull request May 7, 2019
* Update after launch_testing features becoming legacy.

Signed-off-by: Michel Hidalgo <[email protected]>

* Migrate demos tests to new launch_testing API.

Signed-off-by: Michel Hidalgo <[email protected]>

* Stop using injected attributes in launch tests.

Signed-off-by: Michel Hidalgo <[email protected]>

* Add launch_testing_ros as test dependency where necessary.

Signed-off-by: Michel Hidalgo <[email protected]>

* Fix bad process cmd on logging demo tests.

Signed-off-by: Michel Hidalgo <[email protected]>

* Fix bad output filter in logging demo tests.

Signed-off-by: Michel Hidalgo <[email protected]>

* Address peer review comments.

Signed-off-by: Michel Hidalgo <[email protected]>

* Fix failing demo_nodes_cpp launch tests

Signed-off-by: Michel Hidalgo <[email protected]>

* Patch failing demo_nodes_cpp launch tests.

Signed-off-by: Michel Hidalgo <[email protected]>

* Alpha ordered some package.xml files.

Signed-off-by: Michel Hidalgo <[email protected]>

* Extended tests for parameter events.

Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Darby Lim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants