Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix revolute joints with infinite limits not working in SDF #106

Open
wants to merge 5 commits into
base: ros2
Choose a base branch
from
Open

Fix revolute joints with infinite limits not working in SDF #106

wants to merge 5 commits into from

Conversation

Amronos
Copy link

@Amronos Amronos commented Dec 9, 2024

Fixes #105.

@Amronos Amronos force-pushed the fix-inf-revolute-joints branch from ece7567 to 1446c83 Compare December 9, 2024 15:09
@Amronos
Add test
7cc79f8 
Signed-off-by: Aarav Gupta <[email protected]>
@Amronos
Copy link
Author

Amronos commented Dec 9, 2024

I don't really know why the jammy checks are failing, but the noble ones are probably failing because of an error in test_parsing.py or test_flake8.py.
The reasons for the checks failing don't look related to this PR.

@clalancette
Copy link
Collaborator

Thanks, #107 should fix the flake8 errors here.

@clalancette
Copy link
Collaborator

If you rebase onto the latest code on ros2, the flake8 errors should be fixed.

@Amronos
Copy link
Author

Amronos commented Dec 10, 2024

Thanks, should be ready to merge now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

joint_state_publisher_gui gives errors on using revolute joints with inf limits in SDF
2 participants
@Amronos @clalancette