-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image transport tutorial #197
Image transport tutorial #197
Conversation
Signed-off-by: Rebecca Butler <[email protected]>
Signed-off-by: Rebecca Butler <[email protected]>
Signed-off-by: Rebecca Butler <[email protected]>
Signed-off-by: Rebecca Butler <[email protected]>
Signed-off-by: Rebecca Butler <[email protected]>
Signed-off-by: Rebecca Butler <[email protected]>
Signed-off-by: Rebecca Butler <[email protected]>
Signed-off-by: Rebecca Butler <[email protected]>
Signed-off-by: Rebecca Butler <[email protected]>
Signed-off-by: Rebecca Butler <[email protected]>
Signed-off-by: Rebecca Butler <[email protected]>
Pinging @jacobperron and @mjcarroll for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I like the tutorial as it's own package 👍
Signed-off-by: Rebecca Butler <[email protected]>
Signed-off-by: Rebecca Butler <[email protected]>
Signed-off-by: Rebecca Butler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'm trying to get a few other PRs in then I will land this one.
@mjcarroll Friendly ping |
This one got merged without CI, and is causing havoc all over the place (every single build on https://ci.ros2.org/view/nightly/ is broken). I'm going to open a revert PR for now and we'll have to deal with it separately. |
This reverts commit 8cef3db.
Fixes #193
This PR ports the existing
image_transport
tutorials from ROS 1 to ROS 2.The tutorial code now lives in a dedicated
image_transport_tutorial
package. The content from http://wiki.ros.org/image_transport/Tutorials is presented in the README and has been updated to work for ROS 2.