Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image transport tutorial #197

Merged
merged 14 commits into from
Jul 29, 2021

Conversation

rebecca-butler
Copy link
Contributor

Fixes #193

This PR ports the existing image_transport tutorials from ROS 1 to ROS 2.

The tutorial code now lives in a dedicated image_transport_tutorial package. The content from http://wiki.ros.org/image_transport/Tutorials is presented in the README and has been updated to work for ROS 2.

@rebecca-butler
Copy link
Contributor Author

Pinging @jacobperron and @mjcarroll for review

Copy link
Contributor

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like the tutorial as it's own package 👍

image_transport_tutorial/README.md Outdated Show resolved Hide resolved
image_transport_tutorial/README.md Outdated Show resolved Hide resolved
image_transport_tutorial/README.md Outdated Show resolved Hide resolved
image_transport_tutorial/README.md Outdated Show resolved Hide resolved
image_transport_tutorial/README.md Outdated Show resolved Hide resolved
image_transport_tutorial/package.xml Outdated Show resolved Hide resolved
image_transport_tutorial/package.xml Outdated Show resolved Hide resolved
image_transport_tutorial/CMakeLists.txt Outdated Show resolved Hide resolved
image_transport_tutorial/CMakeLists.txt Outdated Show resolved Hide resolved
image_transport_tutorial/package.xml Show resolved Hide resolved
Copy link
Contributor

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobperron jacobperron requested a review from mjcarroll July 13, 2021 20:31
Copy link
Contributor

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm trying to get a few other PRs in then I will land this one.

@jacobperron
Copy link
Contributor

@mjcarroll Friendly ping

@mjcarroll mjcarroll merged commit 8cef3db into ros-perception:ros2 Jul 29, 2021
@clalancette
Copy link
Contributor

clalancette commented Aug 2, 2021

This one got merged without CI, and is causing havoc all over the place (every single build on https://ci.ros2.org/view/nightly/ is broken). I'm going to open a revert PR for now and we'll have to deal with it separately.

clalancette added a commit that referenced this pull request Aug 2, 2021
clalancette added a commit that referenced this pull request Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants