Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JTC] Fill action error_strings #887

Merged
merged 5 commits into from
Jan 31, 2024

Conversation

christophfroehlich
Copy link
Contributor

I found out that the control_msgs::action::FollowJointTrajectory has an error_string field, but it was not populated in some cases.

@christophfroehlich christophfroehlich added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Dec 7, 2023
@christophfroehlich christophfroehlich changed the title [JTC] Action error_strings [JTC] Fill action error_strings Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (9f7e9e9) 47.71% compared to head (dc1c494) 47.72%.
Report is 6 commits behind head on master.

❗ Current head dc1c494 differs from pull request most recent head 8630382. Consider uploading reports for the commit 8630382 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #887      +/-   ##
==========================================
+ Coverage   47.71%   47.72%   +0.01%     
==========================================
  Files          41       41              
  Lines        3871     3876       +5     
  Branches     1833     1832       -1     
==========================================
+ Hits         1847     1850       +3     
  Misses        751      751              
- Partials     1273     1275       +2     
Flag Coverage Δ
unittests 47.72% <11.11%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ory_controller/src/joint_trajectory_controller.cpp 47.08% <11.11%> (-0.04%) ⬇️

... and 3 files with indirect coverage changes

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor comments

@bmagyar bmagyar merged commit 67dbf7b into ros-controls:master Jan 31, 2024
11 of 15 checks passed
mergify bot pushed a commit that referenced this pull request Jan 31, 2024
mergify bot pushed a commit that referenced this pull request Jan 31, 2024
bmagyar pushed a commit that referenced this pull request Jan 31, 2024
bmagyar pushed a commit that referenced this pull request Jan 31, 2024
@christophfroehlich christophfroehlich deleted the jtc/error_strings branch January 31, 2024 21:47
pac48 pushed a commit to pac48/ros2_controllers that referenced this pull request Feb 2, 2024
henrygerardmoore pushed a commit to henrygerardmoore/ros2_controllers that referenced this pull request Jul 19, 2024
This avoids warning when executing formatting action: "Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/setup-python@v2, pre-commit/[email protected]"

For example: https://github.com/ros-controls/ros2_control/actions/runs/3855204458
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants