Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] [ForceTorqueSensorBroadcaster] Create ParamListener and get parameter… #1203

Closed
wants to merge 1 commit into from

Conversation

xueying4402
Copy link

@xueying4402 xueying4402 commented Jul 13, 2024

…s on configure (#698)

  • Create ParamListener and get parameters on configure

  • Declare parameters for test_force_torque_sensor_broadcaster

Since the parameters are not declared on init anymore, they cannot be set without declaring them before


Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:

  1. Limited scope. Your PR should do one thing or one set of things. Avoid adding “random fixes” to PRs. Put those on separate PRs.
  2. Give your PR a descriptive title. Add a short summary, if required.
  3. Make sure the pipeline is green.
  4. Don’t be afraid to request reviews from maintainers.
  5. New code = new tests. If you are adding new functionality, always make sure to add some tests exercising the code and serving as live documentation of your original intention.

To send us a pull request, please:

  • Fork the repository.
  • Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
  • Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
  • Commit to your fork using clear commit messages.
  • Send a pull request, answering any default questions in the pull request interface.
  • Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

…s on configure (ros-controls#698)

* Create ParamListener and get parameters on configure

* Declare parameters for test_force_torque_sensor_broadcaster

Since the parameters are not declared on init anymore, they cannot be
set without declaring them before

---------

Co-authored-by: Bence Magyar <[email protected]>
Copy link
Contributor

mergify bot commented Jul 13, 2024

@xueying4402, all pull requests must be targeted towards the master development branch.
Once merged into master, it is possible to backport to humble, but it must be in master
to have these changes reflected into new distributions.

@christophfroehlich
Copy link
Contributor

christophfroehlich commented Jul 13, 2024

I don't understand your PR. There was already a backport #750. Is this new code now?

Edit: we reverted the change for a good reason #1003 and should not be necessary with #1332 any more

@saikishor
Copy link
Member

Hello!

I agree with @christophfroehlich. This is not needed anymore. You are supposed to declare them in the init and the get them in the configure, so you will be able to change parameters before configuring it again. You should be able to set the parameters at loading time by passing the parameters file path.

Thank you!

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please recheck the approach and get back to us.

@olivier-stasse
Copy link
Contributor

I agree with @christophfroehlich and @saikishor

@xueying4402
Copy link
Author

@christophfroehlich @saikishor @olivier-stasse Thank you for the feedback. I have confirmed that the issue addressed in this PR was previously resolved and then rolled back. I apologize for any oversight on my part.
The intent behind this submission was to fix the same bug in the humble release. However, it seems this is no longer necessary.
Thank you for your patience and guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants