Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip][STEERING]: Add swerve drive #1148

Closed
wants to merge 2 commits into from
Closed

[wip][STEERING]: Add swerve drive #1148

wants to merge 2 commits into from

Conversation

qinqon
Copy link
Contributor

@qinqon qinqon commented May 24, 2024

Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:

  1. Limited scope. Your PR should do one thing or one set of things. Avoid adding “random fixes” to PRs. Put those on separate PRs.
  2. Give your PR a descriptive title. Add a short summary, if required.
  3. Make sure the pipeline is green.
  4. Don’t be afraid to request reviews from maintainers.
  5. New code = new tests. If you are adding new functionality, always make sure to add some tests exercising the code and serving as live documentation of your original intention.

To send us a pull request, please:

  • Fork the repository.
  • Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
  • Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
  • Commit to your fork using clear commit messages.
  • Send a pull request, answering any default questions in the pull request interface.
  • Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

@qinqon qinqon force-pushed the swerve-drive branch 6 times, most recently from 145beaa to 715c8a0 Compare May 27, 2024 19:51
@qinqon qinqon force-pushed the swerve-drive branch 6 times, most recently from 92a01a3 to 0307a05 Compare June 4, 2024 17:23
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 5, 2024

This pull request is in conflict. Could you fix it @qinqon?

@qinqon qinqon force-pushed the swerve-drive branch 3 times, most recently from ed51226 to c07bd4e Compare June 8, 2024 08:01
@qinqon
Remove front_steering from steering library
c83dce3 
To Accommodate controllers that are not only steering at front or rear
this change remove the `front_steering` variable from
steering_controller_library, as a byproduct of that the the notino of
front or rear wheel radius is also removed from dependant controllers
and the library has know "wheels" and "steers" joints.

Signed-off-by: Quique Llorente <[email protected]>
@qinqon
[STEERING]: Add swerve drive
5b2ba7f 
Signed-off-by: Quique Llorente <[email protected]>
@qinqon qinqon closed this Jul 3, 2024
henrygerardmoore pushed a commit to henrygerardmoore/ros2_controllers that referenced this pull request Jul 19, 2024
@dependabot
Bump ros-tooling/action-ros-ci from 0.3.3 to 0.3.4 (ros-controls#1148)
971ff39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@qinqon