Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements to the error output in component parser to make debugging easier. (backport #1580) #1582

Merged
merged 3 commits into from
Jul 13, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 19, 2024


This is an automatic backport of pull request #1580 done by [Mergify](https://mergify.com).

…bugging easier. (#1580)

* Small improvements to the error output in component parser to make debugging easier.

* Correct formatting.

(cherry picked from commit fbb893b)

# Conflicts:
#	hardware_interface/src/component_parser.cpp
Copy link
Contributor Author

mergify bot commented Jun 19, 2024

Cherry-pick of fbb893b has failed:

On branch mergify/bp/iron/pr-1580
Your branch is up to date with 'origin/iron'.

You are currently cherry-picking commit fbb893b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   hardware_interface/src/component_parser.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.45%. Comparing base (3abe840) to head (8e8faf2).

Additional details and impacted files
@@            Coverage Diff             @@
##             iron    #1582      +/-   ##
==========================================
- Coverage   87.45%   87.45%   -0.01%     
==========================================
  Files         101      101              
  Lines        8078     8080       +2     
  Branches      711      711              
==========================================
+ Hits         7065     7066       +1     
- Misses        717      718       +1     
  Partials      296      296              
Flag Coverage Δ
unittests 87.45% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
hardware_interface/src/component_parser.cpp 93.69% <50.00%> (-0.40%) ⬇️

@christophfroehlich christophfroehlich merged commit 5ab3bd2 into iron Jul 13, 2024
10 of 11 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/iron/pr-1580 branch July 13, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants