Reactivate generate_version_header for joint_limits #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@christophfroehlich let's wait a bit more even for the backports to be released. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1544 +/- ##
=======================================
Coverage 87.70% 87.70%
=======================================
Files 102 102
Lines 8702 8702
Branches 780 780
=======================================
Hits 7632 7632
Misses 790 790
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more. |
destogl
approved these changes
May 22, 2024
christophfroehlich
force-pushed
the
activate_cmake_gen_version
branch
from
04e7f7a
to
1d645c2
Compare
github-actions
bot
requested review from
aprotyas,
bmagyar,
destogl,
jaron-l,
mcbed,
moriarty and
saikishor
saikishor
approved these changes
Jun 2, 2024
Let's see if the buildfarm is happy now with it ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was deactivated with #1534 and the build farm is happy now
https://build.ros2.org/job/Rbin_uN64__joint_limits__ubuntu_noble_amd64__binary/
After ament/ament_cmake#529 is merged (backport to jazzy, held back until the first patch release) we can reactivate it.