-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KalmanFilter for rmoss_util #44
base: humble
Are you sure you want to change the base?
Conversation
baiyeweiguang
commented
Jul 22, 2024
- 修改了rmoss_util文件结构,分为common和math两个模块
- 参考ADEKF、rm.cv.fans等开源实现了自动求Jacobian的扩展卡尔曼滤波器,但是引入了新依赖Ceres
- 由于依赖的增加,修改了.github/workflows/ci.yml
@@ -16,6 +16,9 @@ jobs: | |||
uses: actions/checkout@v3 | |||
with: | |||
fetch-depth: 0 | |||
- name: Pre install | |||
run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI这里可以改成使用rosdep install吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ros-ci会运行rosdep install命令,但似乎不能正确安装libceres-dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以增加math目录层级,但是你这样的增加方式感觉有点怪,建议如下层级:
- rmoss_util
- include/rmoss_util/math/extended_kalman_filter.hpp
- src
不加math目录主要是考虑contrib那里的包用到了原来的util里的东西,如果加了math那common也要加,这样还得改对应的路径 |
common目录没必要加,其他代码可以不动,只给extended_kalman_filter.hpp加一级math就行,像这样
rmoss_contrib准备archive了,也可以先不管它。 |