Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KalmanFilter for rmoss_util #44

Open
wants to merge 10 commits into
base: humble
Choose a base branch
from

Conversation

baiyeweiguang
Copy link
Contributor

  • 修改了rmoss_util文件结构,分为common和math两个模块
  • 参考ADEKF、rm.cv.fans等开源实现了自动求Jacobian的扩展卡尔曼滤波器,但是引入了新依赖Ceres
  • 由于依赖的增加,修改了.github/workflows/ci.yml

rmoss_util/README.md Outdated Show resolved Hide resolved
rmoss_util/math/test/CMakeLists.txt Outdated Show resolved Hide resolved
@@ -16,6 +16,9 @@ jobs:
uses: actions/checkout@v3
with:
fetch-depth: 0
- name: Pre install
run: |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI这里可以改成使用rosdep install吗?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ros-ci会运行rosdep install命令,但似乎不能正确安装libceres-dev

Copy link
Member

@gezp gezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以增加math目录层级,但是你这样的增加方式感觉有点怪,建议如下层级:

  • rmoss_util
    • include/rmoss_util/math/extended_kalman_filter.hpp
    • src

@baiyeweiguang
Copy link
Contributor Author

可以增加math目录层级,但是你这样的增加方式感觉有点怪,建议如下层级:

  • rmoss_util
    • include/rmoss_util/math/extended_kalman_filter.hpp
    • src

不加math目录主要是考虑contrib那里的包用到了原来的util里的东西,如果加了math那common也要加,这样还得改对应的路径

@gezp
Copy link
Member

gezp commented Jul 22, 2024

可以增加math目录层级,但是你这样的增加方式感觉有点怪,建议如下层级:

  • rmoss_util

    • include/rmoss_util/math/extended_kalman_filter.hpp
    • src

不加math目录主要是考虑contrib那里的包用到了原来的util里的东西,如果加了math那common也要加,这样还得改对应的路径

common目录没必要加,其他代码可以不动,只给extended_kalman_filter.hpp加一级math就行,像这样
rmoss_util

  • include/rmoss_util/
    • mono_measure_tool.hpp
    • math/extended_kalman_filter.hpp
  • src

rmoss_contrib准备archive了,也可以先不管它。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants