-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GetLibraryItemAsyncEnumerable for unlimited library books #27
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
8406f20
Add GetLibraryItemAsyncEnumerable for unlimited library books
Mbucari 4d2f681
Make truly async so all Items are downloaded as fast as possible.
Mbucari 7d3ff30
Add comment
Mbucari 7a6b9d6
Only store Items from most recent call to Api
Mbucari 1bf75a7
Use Task instead of ValueTask when awaiting more than once.
Mbucari 2acec32
No need to convert to json then back to string
Mbucari b216996
Add error handling and retrying
Mbucari e71dc06
Make ItemAsyncEnumerable a hybrid that can make parallel requests for…
Mbucari 3abbaf8
Default NumberOfResultPerPage is 250
Mbucari 478adef
Off by 1
Mbucari 25e4bdd
Redesign and simplify GetLibraryItemAsyncEnumerable
Mbucari 8b41d34
Change default get size to 50
Mbucari 773a20d
Better naming
Mbucari 81684bf
Parameterize request count and max concurrency
Mbucari f648251
Refactor for clarity
Mbucari File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What kinda weird find + replace must I have done to cause this??