Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GetLibraryItemAsyncEnumerable for unlimited library books #27

Merged
merged 15 commits into from
May 26, 2022
Merged

Add GetLibraryItemAsyncEnumerable for unlimited library books #27

merged 15 commits into from
May 26, 2022

Commits on May 25, 2022

  1. Add GetLibraryItemAsyncEnumerable for unlimited library books

    @Mbucari
    Mbucari committed May 25, 2022
    Configuration menu
    Copy the full SHA
    8406f20 View commit details
    Browse the repository at this point in the history

  2. Make truly async so all Items are downloaded as fast as possible.

    @Mbucari
    Mbucari committed May 25, 2022
    Configuration menu
    Copy the full SHA
    4d2f681 View commit details
    Browse the repository at this point in the history

  3. Add comment

    @Mbucari
    Mbucari committed May 25, 2022
    Configuration menu
    Copy the full SHA
    7d3ff30 View commit details
    Browse the repository at this point in the history

  4. Only store Items from most recent call to Api

    @Mbucari
    Mbucari committed May 25, 2022
    Configuration menu
    Copy the full SHA
    7a6b9d6 View commit details
    Browse the repository at this point in the history

  5. Use Task instead of ValueTask when awaiting more than once.

    @Mbucari
    Mbucari committed May 25, 2022
    Configuration menu
    Copy the full SHA
    1bf75a7 View commit details
    Browse the repository at this point in the history

  6. No need to convert to json then back to string

    @Mbucari
    Mbucari committed May 25, 2022
    Configuration menu
    Copy the full SHA
    2acec32 View commit details
    Browse the repository at this point in the history

  7. Add error handling and retrying

    @Mbucari
    Mbucari committed May 25, 2022
    Configuration menu
    Copy the full SHA
    b216996 View commit details
    Browse the repository at this point in the history

  8. Make ItemAsyncEnumerable a hybrid that can make parallel requests for… 

    … libraries < 10000 books
    @Mbucari
    Mbucari committed May 25, 2022
    Configuration menu
    Copy the full SHA
    e71dc06 View commit details
    Browse the repository at this point in the history

  9. Default NumberOfResultPerPage is 250

    @Mbucari
    Mbucari committed May 25, 2022
    Configuration menu
    Copy the full SHA
    3abbaf8 View commit details
    Browse the repository at this point in the history

  10. Off by 1

    @Mbucari
    Mbucari committed May 25, 2022
    Configuration menu
    Copy the full SHA
    478adef View commit details
    Browse the repository at this point in the history

  11. Redesign and simplify GetLibraryItemAsyncEnumerable

    @Mbucari
    Mbucari committed May 25, 2022
    Configuration menu
    Copy the full SHA
    25e4bdd View commit details
    Browse the repository at this point in the history

  12. Change default get size to 50

    @Mbucari
    Mbucari committed May 25, 2022
    3 Configuration menu
    Copy the full SHA
    8b41d34 View commit details
    Browse the repository at this point in the history

  13. Better naming

    @Mbucari
    Mbucari committed May 25, 2022
    Configuration menu
    Copy the full SHA
    773a20d View commit details
    Browse the repository at this point in the history

  14. Parameterize request count and max concurrency

    @Mbucari
    Mbucari committed May 25, 2022
    Configuration menu
    Copy the full SHA
    81684bf View commit details
    Browse the repository at this point in the history

  15. Refactor for clarity

    @Mbucari
    Mbucari committed May 25, 2022
    Configuration menu
    Copy the full SHA
    f648251 View commit details
    Browse the repository at this point in the history