-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/tools cleanup #2
Open
hillct
wants to merge
2
commits into
rjocoleman:master
Choose a base branch
from
hillct:feature/toolsCleanup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,33 @@ | ||
FROM alpine:3.3 | ||
FROM alpine:edge | ||
|
||
# the following ENV need to be present | ||
ENV IAM_ROLE=none | ||
ENV MOUNT_POINT=/var/s3 | ||
VOLUME /var/s3 | ||
|
||
ARG S3FS_VERSION=v1.79 | ||
|
||
RUN apk --update add fuse alpine-sdk automake autoconf libxml2-dev fuse-dev curl-dev git bash; | ||
RUN git clone https://github.com/s3fs-fuse/s3fs-fuse.git; \ | ||
cd s3fs-fuse; \ | ||
git checkout tags/${S3FS_VERSION}; \ | ||
./autogen.sh; \ | ||
./configure --prefix=/usr; \ | ||
make; \ | ||
make install; \ | ||
rm -rf /var/cache/apk/*; | ||
ARG S3FS_VERSION=v1.80 | ||
# Build-time metadata as defined at http://label-schema.org | ||
ARG BUILD_DATE | ||
ARG VCS_REF | ||
ARG VCS_URL | ||
ARG VERSION | ||
LABEL org.label-schema.build-date=$BUILD_DATE \ | ||
org.label-schema.name="Alpine/s3fs - Alpine Linux image w/Amazon S3 Support through Fuse-s3fs" \ | ||
# org.label-schema.description="Let it be pulled from Readme.md..." \ | ||
org.label-schema.url="https://github.com/rjocoleman/docker-alpine-s3fs/wiki" \ | ||
org.label-schema.vcs-ref=$VCS_REF \ | ||
org.label-schema.vcs-url=$VCS_URL \ | ||
org.label-schema.vendor="Robert Coleman <[email protected]>" \ | ||
org.label-schema.version=$VERSION \ | ||
org.label-schema.schema-version="1.0" | ||
RUN apk update && apk upgrade \ | ||
&& apk add --no-cache ca-certificates fuse libcurl libxml2 bash \ | ||
&& apk add --no-cache --virtual .build-dependencies \ | ||
alpine-sdk automake autoconf libxml2-dev fuse-dev curl-dev git \ | ||
&& git clone https://github.com/s3fs-fuse/s3fs-fuse.git \ | ||
&& cd s3fs-fuse && git checkout tags/${S3FS_VERSION} \ | ||
&& ./autogen.sh && ./configure --prefix=/usr && make && make install && cd .. \ | ||
&& apk del .build-dependencies && rm -rf /var/cache/* s3fs-fuse | ||
|
||
COPY docker-entrypoint.sh / | ||
ENTRYPOINT ["/docker-entrypoint.sh"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
#!/bin/bash | ||
FOO=${IMAGE_NAME:=`whoami`/docker-alpine-s3fs:local} | ||
BAR=${SOURCE_BRANCH:=`git rev-parse --abbrev-ref HEAD`} | ||
docker build --build-arg BUILD_DATE=`date -u +"%Y-%m-%dT%H:%M:%SZ"` \ | ||
--build-arg VCS_REF=`git rev-parse --short HEAD` \ | ||
--build-arg VCS_URL=`git config --get remote.origin.url` \ | ||
--build-arg VERSION=$SOURCE_BRANCH -t $IMAGE_NAME . |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hillct what are
FOO
andBAR
doing here? they're set and not used?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're correct that FOO and BAR are not used. It was done that way for syntactic cleanliness. The lifespan of those variables are minimal and not of any consequence to the build process but it did provide clarity in the Assembly of the image name and Source Branch variables. The same result could be achieved using multi line if conditionals but this seemed clearer, overall.