Feature/tools cleanup #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…us size, addition of autobuild hooks and microbadger labels
It's worth noting that your repo should be converted to an automated build similar to https://hub.docker.com/r/hillct/docker-alpine-s3fs/ with branches for each of latest/edge, 3.3 and ruby
|
thanks @hillct, there's a lot of changes in this PR. I'll need some time to check them all |
rjocoleman
reviewed
Feb 1, 2017
| @@ -0,0 +1,7 @@ | |||
| #!/bin/bash | |||
| FOO=${IMAGE_NAME:=`whoami`/docker-alpine-s3fs:local} | |||
| BAR=${SOURCE_BRANCH:=`git rev-parse --abbrev-ref HEAD`} | |||
There was a problem hiding this comment.
@hillct what are FOO and BAR doing here? they're set and not used?
There was a problem hiding this comment.
You're correct that FOO and BAR are not used. It was done that way for syntactic cleanliness. The lifespan of those variables are minimal and not of any consequence to the build process but it did provide clarity in the Assembly of the image name and Source Branch variables. The same result could be achieved using multi line if conditionals but this seemed clearer, overall.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the docker file to remove the build tools after the build is complete, reducing the image size by over 90% also adding automated build hooks with label metadata additions. Also updated to Alpine 3.4 and Fuse-s3fs 1.80. The build hooks are intended to interoperate with the Docker Hub Automated build system. See https://hub.docker.com/r/hillct/docker-alpine-s3fs/tags/