Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: rename PDF/ePUB filename to valid one automatically #11198

Merged
merged 15 commits into from
Jul 11, 2024
Merged

Build: rename PDF/ePUB filename to valid one automatically #11198

merged 15 commits into from
Jul 11, 2024

Commits on Mar 8, 2024

  1. Build: rename PDF/ePUB filename to valid one automatically 

    Currently, we _require_ the user to save the PDF or ePUB file with a pretty
specific filename: `{project.slug}-{version.slug}.{extension}`. This has caused
a lot of confusions to users.

Since we only support 1 file for PDF/ePUB for now, we can rename this file to
the valid filename automatically.

Closes #10873
    @humitos
    humitos committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    fd209e1 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Merge branch 'main' of github.com:readthedocs/readthedocs.org into hu… 

    …mitos/allow-any-filename-pdf-epub
    @humitos
    humitos committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    0ad1b62 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Rename the offline format file properly

    @humitos
    humitos committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    be8b5d7 View commit details
    Browse the repository at this point in the history

  2. Initial attempt to write a test case

    @humitos
    humitos committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    76ab170 View commit details
    Browse the repository at this point in the history

  3. Revert "Initial attempt to write a test case" 

    This reverts commit 76ab170.
    @humitos
    humitos committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    788dedf View commit details
    Browse the repository at this point in the history

  4. Test case and filename fix

    @humitos
    humitos committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    17e91d9 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into humitos/allow-any-filename-pdf-epub

    @humitos
    humitos committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    f8f860f View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Remove the conditional that's not needed

    @humitos
    humitos committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    38d3649 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Merge branch 'main' of github.com:readthedocs/readthedocs.org into hu… 

    …mitos/allow-any-filename-pdf-epub
    @humitos
    humitos committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    515b5e4 View commit details
    Browse the repository at this point in the history

  2. Assert the path is inside OUTPUT dir before calling shutil.move

    @humitos
    humitos committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    e9a0f08 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Revert "Assert the path is inside OUTPUT dir before calling `shutil.m… 

    …ove`"

This reverts commit e9a0f08.
    @humitos
    humitos committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    d5bdfdc View commit details
    Browse the repository at this point in the history

  2. Assert the path is inside the DOCROOT before calling shutil.move

    @humitos
    humitos committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    8bc4093 View commit details
    Browse the repository at this point in the history

  3. Update readthedocs/projects/tasks/builds.py 

    Co-authored-by: Santos Gallegos <[email protected]>
    @humitos @stsewd
    humitos and stsewd committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    a570bfb View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Merge branch 'main' of github.com:readthedocs/readthedocs.org into hu… 

    …mitos/allow-any-filename-pdf-epub
    @humitos
    humitos committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    e9db5fb View commit details
    Browse the repository at this point in the history

  2. Update tests

    @humitos
    humitos committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    351d5e4 View commit details
    Browse the repository at this point in the history