Build: rename PDF/ePUB filename to valid one automatically #11198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we _require_ the user to save the PDF or ePUB file with a pretty
specific filename: `{project.slug}-{version.slug}.{extension}`. This has caused
a lot of confusions to users.
Since we only support 1 file for PDF/ePUB for now, we can rename this file to
the valid filename automatically.
Closes #10873
…mitos/allow-any-filename-pdf-epub
This reverts commit 76ab170.
stsewd
reviewed
Jun 26, 2024
…mitos/allow-any-filename-pdf-epub
|
This is ready to re-review and merge 👍🏼 |
stsewd
reviewed
Jul 9, 2024
stsewd
reviewed
Jul 9, 2024
Co-authored-by: Santos Gallegos <[email protected]>
stsewd
approved these changes
Jul 9, 2024
…mitos/allow-any-filename-pdf-epub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we require the user to save the PDF or ePUB file with a pretty specific filename:
{project.slug}.{extension}. This has caused a lot of confusions to users.Since we only support 1 file for PDF/ePUB for now, we can rename this file to the valid filename automatically.
Closes #10873