Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add windows memory search support #18585

Closed
wants to merge 3 commits into from
Closed

Add windows memory search support #18585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b757c9
Add Needle Length TLV
sjanusz-r7 Nov 29, 2023
f8a4f22
Add Needle Length to memory search request
sjanusz-r7 Nov 29, 2023
5de9b01
Use bytesize for needle size
sjanusz-r7 Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/rex/post/meterpreter/extensions/stdapi/sys/process_subsystem/memory.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,10 @@ def search(needles, min_search_len = 5, match_len = 500)
request = Packet.create_request(COMMAND_ID_STDAPI_SYS_PROCESS_MEMORY_SEARCH)

request.add_tlv(TLV_TYPE_PID, process.pid)
needles.each { | needle | request.add_tlv(TLV_TYPE_MEMORY_SEARCH_NEEDLE, needle) }
needles.each do | needle |
request.add_tlv(TLV_TYPE_MEMORY_SEARCH_NEEDLE, needle)
request.add_tlv(TLV_TYPE_MEMORY_SEARCH_NEEDLE_LEN, needle.bytesize)
Copy link
Contributor

@adfoster-r7 adfoster-r7 Nov 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems odd that we need this additional information, when the length value is already baked into the TLV itself (Type Length Value)

I wonder if this is being added as a workaround for your current Meterpreter implementation? 🤔

end
request.add_tlv(TLV_TYPE_MEMORY_SEARCH_MATCH_LEN, match_len)
request.add_tlv(TLV_TYPE_UINT, min_search_len)

Expand Down
1 change: 1 addition & 0 deletions lib/rex/post/meterpreter/extensions/stdapi/tlv.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@ module Stdapi
TLV_TYPE_MEMORY_SEARCH_SECT_LEN = TLV_META_TYPE_QWORD | 2654
TLV_TYPE_MEMORY_SEARCH_MATCH_ADDR = TLV_META_TYPE_QWORD | 2655
TLV_TYPE_MEMORY_SEARCH_MATCH_STR = TLV_META_TYPE_STRING | 2656
TLV_TYPE_MEMORY_SEARCH_NEEDLE_LEN = TLV_META_TYPE_UINT | 2657

##
#
Expand Down