Add windows memory search support #18585
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfoster-r7
reviewed
Nov 29, 2023
lib/rex/post/meterpreter/extensions/stdapi/sys/process_subsystem/memory.rb
Outdated
Show resolved
Hide resolved
adfoster-r7
reviewed
Nov 30, 2023
| needles.each { | needle | request.add_tlv(TLV_TYPE_MEMORY_SEARCH_NEEDLE, needle) } | ||
| needles.each do | needle | | ||
| request.add_tlv(TLV_TYPE_MEMORY_SEARCH_NEEDLE, needle) | ||
| request.add_tlv(TLV_TYPE_MEMORY_SEARCH_NEEDLE_LEN, needle.bytesize) |
There was a problem hiding this comment.
It seems odd that we need this additional information, when the length value is already baked into the TLV itself (Type Length Value)
I wonder if this is being added as a workaround for your current Meterpreter implementation? 🤔
|
Closing this in favour of the approach specified in the above comment 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is needed to correctly support null-bytes in the Windows memory search implementation using regex. The PR for that functionality is here: rapid7/metasploit-payloads#686
By explicitly specifying the needle length, the needle can contain null bytes (to support searching for wide chars, e.g. "\x41\x00") and they will not be treated as the end of the string. The same approach was used to search over null bytes in the memory buffers.
Verification
msfconsole