Refactor catalogue category e2e tests #314

[joelvdavies]

Description

Refactors catalogue category e2e tests. Also applies changes to all refactored tests so far to match the style of #31.

Notes

Removed tests:

• test_create_catalogue_category_with_properties_with_allowed_values - Tested by the new test_create_leaf_with_properties
• test_partial_update_catalogue_category_change_from_leaf_to_non_leaf - With the way it is currently written test_partial_update_is_leaf_no_children should be enough for leaf -> non leaf or non-leaf -> leaf as it doesn't care about the value change itself, just whether it is allowed to modify it
• test_partial_update_catalogue_category_add_property, test_partial_update_catalogue_category_remove_property and test_partial_update_catalogue_category_modify_property replaced with one test updating properties (add and removal is irrelevant here)

Testing instructions

Add a set up instructions describing how the reviewer should test the code

• Review code
• Check Actions build
• Review changes to test coverage

Agile board tracking

Closes #314

[VKTB]

Comments so far before looking at test/e2e/test_catalogue_category.py

[VKTB]

Could you please also run the black formatter as it has some things to reformat? Thanks

[joelvdavies]

Could you please also run the black formatter as it has some things to reformat? Thanks

I thought I did on the latest force push?

[VKTB]

Could you please also run the black formatter as it has some things to reformat? Thanks

I thought I did on the latest force push?

Oh sorry, your last commit did not appear for me when I posted this.

[joelvdavies]

@VKTB Thanks for being thorough and spotting these, I wouldn't have myself.