Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Fix typos #332

Merged
merged 3 commits into from
Jul 7, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pytorch_vision_vgg.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,12 @@ for i in range(top5_prob.size(0)):
### Model Description

Here we have implementations for the models proposed in [Very Deep Convolutional Networks for Large-Scale Image Recognition](https://arxiv.org/abs/1409.1556),
for each configurations and their with bachnorm version.
for each configurations and their with batchnorm version.

For example, configuration `A` presented in the paper is `vgg11`, configuration `B` is `vgg13`, configuration `D` is `vgg16`
and configuration `E` is `vgg19`. Their batchnorm version are suffixed with `_bn`.

Their 1-crop error rates on imagenet dataset with pretrained models are listed below.
Their Top-1 error rates on ImageNet dataset with pretrained models are listed below.

| Model structure | Top-1 error | Top-5 error |
| --------------- | ----------- | ----------- |
Expand Down
3 changes: 2 additions & 1 deletion scripts/install_deps.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ conda install -y regex pillow tqdm boto3 requests numpy h5py scipy matplotlib un
conda install -y -c conda-forge librosa inflect

pip install -q fastBPE sacremoses sentencepiece subword_nmt editdistance
pip install -q visdom mistune filelock tokenizers packaging pandas
pip install -q visdom filelock tokenizers packaging pandas
pip install -q mistune==2.0.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it's a short thought
Checked the following logs and ran a downgrade.
https://circleci.com/gh/pytorch/hub/2694

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was no problem with the history of merged without errors until 2022, and the mistune version at that time was 2.0.4.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A build error was displayed.
What do you think about modifying all libraries installed before a specific date to a version

  • If the torch version goes down to the 1.x version, does it cause problems with interaction with other org pages?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the typo fixes @cpprhtn. Do you mind reverting those install changes in this PR so that we can merge it? We can follow-up on the install issue on another PR. I see you already opened #333, thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review!

pip install -q omegaconf timm seaborn importlib_metadata huggingface_hub
pip install -q hydra-core opencv-python fvcore
pip install -q --upgrade google-api-python-client
Expand Down