[Minor] Fix typos #332
Merged
[Minor] Fix typos #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-hub-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
#333 |
|
@vmoens can you review about this? |
vmoens
reviewed
Jul 7, 2023
scripts/install_deps.sh
Outdated
| @@ -12,7 +12,8 @@ conda install -y regex pillow tqdm boto3 requests numpy h5py scipy matplotlib un | |||
| conda install -y -c conda-forge librosa inflect | |||
|
|
|||
| pip install -q fastBPE sacremoses sentencepiece subword_nmt editdistance | |||
| pip install -q visdom mistune filelock tokenizers packaging pandas | |||
| pip install -q visdom filelock tokenizers packaging pandas | |||
| pip install -q mistune==2.0.2 | |||
There was a problem hiding this comment.
I don't know if it's a short thought
Checked the following logs and ran a downgrade.
https://circleci.com/gh/pytorch/hub/2694
There was a problem hiding this comment.
There was no problem with the history of merged without errors until 2022, and the mistune version at that time was 2.0.4.
There was a problem hiding this comment.
A build error was displayed.
What do you think about modifying all libraries installed before a specific date to a version
- If the torch version goes down to the 1.x version, does it cause problems with interaction with other org pages?
There was a problem hiding this comment.
Thank you for your review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bachnorm->batchnormimagenet->ImageNetBecause ImageNet is a proper noun, it retains the ImageNet word