Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix onnx prediction #202

Merged
merged 7 commits into from
May 29, 2024
Merged

Fix onnx prediction #202

merged 7 commits into from
May 29, 2024

Conversation

MateoLostanlen
Copy link
Member

@MateoLostanlen MateoLostanlen commented May 28, 2024

Hi, I hadn't done a test with images of different sizes and I realized that the resize was not adapted. We don't need a letterbox (as is the case when training) but simply the following resizing.

I modified the model in onnx format on hugging face by exporting with the “dynamic” parameter to adapt to any image size. The dimensions simply have to be a multiple of 32

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.84%. Comparing base (45b19e0) to head (75d7466).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #202      +/-   ##
===========================================
- Coverage    87.92%   87.84%   -0.09%     
===========================================
  Files            6        6              
  Lines          381      362      -19     
===========================================
- Hits           335      318      -17     
+ Misses          46       44       -2     
Flag Coverage Δ
unittests 87.84% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MateoLostanlen MateoLostanlen self-assigned this May 28, 2024
@MateoLostanlen MateoLostanlen added the type: bug Something isn't working label May 28, 2024
@MateoLostanlen MateoLostanlen requested review from RonanMorgan and a team May 28, 2024 16:37
@RonanMorgan RonanMorgan merged commit c18de6b into develop May 29, 2024
14 checks passed
@RonanMorgan RonanMorgan deleted the fix_onnx_prediction branch May 29, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants