-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Donwload model only when needed #200
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #200 +/- ##
===========================================
+ Coverage 87.84% 88.91% +1.07%
===========================================
Files 6 6
Lines 362 397 +35
===========================================
+ Hits 318 353 +35
Misses 44 44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Ronan, this looks togood to me. Just can you change the model path and hash based on PR #202
This code is :
TODO : we still need to create a new path name in huggingface space in order to have a "neutral name" (like pyronear/model.onnx) and not having to change the value in the code each time @MateoLostanlen