Remove shortcut indicator search dialog on small screens #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes pydata#1944. Alternative to pydata#1945.
drammock
approved these changes
Aug 6, 2024
Carreau
approved these changes
Aug 7, 2024
|
Is there anything to do on my side? The CI failure seems unrelated. |
|
Failure will be fixed by spatialaudio/nbsphinx#807, so nothing to do on your side I think. |
Coverage report
This PR does not seem to contain any modification to coverable code. |
|
Reran failed test, it's passing now. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1944.
Alternative to #1945. While #1945 removes the shortcut completely, I've suggested that it actually has value and should only be removed on smaller screens. That's what this PR implements. It shows the shortcuts if the window size is at least "md" i.e. >=768px (I figured, this is a reasonable threshold - see discussion below, but if you think other values are better, that's perfectly fine).
Search on small screens (IPhone Pro Max size)
The minimum width with shortcuts is illustrated in the following screenshot. With this the search field is large enough that the shortcut on the right is not cluttering/distracting from the "Search the docs ..." message. On the other end, I'd consider that size about the minimum size a user would give a browser window to read docs. If the window size is smaller, it's unlikely that the user is using a "large" device with a keyboard attached, and hence the shortcut is not needed.
