Skip to content

Commit

Permalink
Remove shortcut indicator search dialog on small screens (#1947)
Browse files Browse the repository at this point in the history
Closes #1944.

Alternative to #1945. While #1945 removes the shortcut completely, I've
[suggested that it actually has
value](#1945 (comment))
and should only be removed on smaller screens. That's what this PR
implements. It shows the shortcuts if the window size is at least "md"
i.e. >=768px (I figured, this is a reasonable threshold - see discussion
below, but if you think other values are better, that's perfectly fine).

See pull requests for screenshots.
  • Loading branch information
timhoffm authored Aug 15, 2024
1 parent c91e2f2 commit 019ad51
Showing 1 changed file with 5 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,13 @@

// Shows off the keyboard shortcuts for the button
.search-button__kbd-shortcut {
display: flex;
display: none;
margin-inline-end: 0.5rem;
color: var(--pst-color-border);

@include media-breakpoint-up(md) {
display: flex;
}
}
}

Expand Down

0 comments on commit 019ad51

Please sign in to comment.