Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various table fixes #1833

Merged
merged 1 commit into from
May 27, 2024
Merged

Various table fixes #1833

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions src/pydata_sphinx_theme/assets/styles/content/_tables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@
table {
@include table-colors;

display: table;
overflow: auto;

Comment on lines -9 to -11
Copy link
Collaborator Author

@gabalafou gabalafou May 27, 2024 •
edited by Carreau
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of flip-flop history here:

As I discuss in issue #1824, it's probably a bad idea to change the display property of a table element since that might strip it of its semantics. And there's no need to explicitly put display: table on the table element, because that's what browsers assume.

As for the overflow rule, it only made sense when the table had display: block, as I discuss in PR #1827.

So to reduce head-scratching for future devs, I'm removing both rules.

// default to table-center
margin-left: auto;
margin-right: auto;
Expand All @@ -33,15 +30,15 @@ table caption {
// MyST Markdown tables use these classes to control alignment
th,
td {
&.text-align\:left {
&.text-left {
text-align: left;
}

&.text-align\:right {
&.text-right {
text-align: right;
}

&.text-align\:center {
&.text-center {
Comment on lines +33 to +41
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These classes were changed in executablebooks/MyST-Parser#450

text-align: center;
}
}
Expand All @@ -57,7 +54,7 @@ td {
}

.pst-scrollable-table-container {
// Put a scrollbar just below tables that are too wide to fit within the main
// column
// Put a horizontal scrollbar just below tables that are too wide to fit
// within the main column
overflow-x: auto;
}
Loading