Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylelint fixes #1823

Merged
merged 6 commits into from
May 27, 2024
Merged

Stylelint fixes #1823

merged 6 commits into from
May 27, 2024

Conversation

gabalafou
Copy link
Collaborator

@gabalafou gabalafou commented May 17, 2024

This PR

  • Adds the stylelint pre-commit hook
  • Adds stylelint config
  • Fixes stylelint errors

This PR includes both autofixes and manual fixes.

@gabalafou
Copy link
Collaborator Author

gabalafou commented May 17, 2024

Based on previous discussion in #1821 and #1764, the plan to get these changes into the main branch is as follows:

  1. Temporarily enable and use rebase-merge to merge this PR so that the commits do not get squashed together
  2. Open a subsequent PR to add the stylelint fix commits (the last three) to .git-blame-ignore-revs

Copy link

github-actions bot commented May 17, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Collaborator Author

@gabalafou gabalafou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-review

@trallard trallard added the kind: maintenance Improving maintainability and reducing technical debt label May 19, 2024
@Carreau
Copy link
Collaborator

Carreau commented May 22, 2024

This got a minor conflict. As you want to rebase and use .git-ignore-revs, Im going to let you do it.

@gabalafou gabalafou force-pushed the stylelint-hook-run branch 2 times, most recently from 5e4c75d to 0d6c5a3 Compare May 22, 2024 11:32
@Carreau
Copy link
Collaborator

Carreau commented May 27, 2024

@gabalafou do you want to rebase-merge this ? I think it has waited long enough.

@gabalafou gabalafou merged commit 69f1a42 into pydata:main May 27, 2024
18 checks passed
@gabalafou gabalafou deleted the stylelint-hook-run branch May 27, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: maintenance Improving maintainability and reducing technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants