Add stylelint hook and config #1821
Conversation
There was a problem hiding this comment.
Ideally I'd prefer the addition of the config in a separate PR from the linter-induced changes, but that seems hard given our pre-commit CI setup. So in this case I would be in favor of
- just before merging, rebase so that there are exactly 2 commits here (one to add tooling, one for linter changes)
- temporarily enable rebase-merges, and merge via rebase
- in subsequent PR, add the second commit to
.git-blame-ignore-revs
| appearance: none; | ||
| appearance: none; |
There was a problem hiding this comment.
redundant after linter fix
| user-select: none; | ||
| -webkit-user-select: text; /* Safari fallback only */ | ||
| -webkit-user-select: none; /* Chrome/Safari */ | ||
| -moz-user-select: none; /* Firefox */ | ||
| -ms-user-select: none; /* IE10+ */ | ||
| user-select: text; /* Safari fallback only */ | ||
| user-select: none; /* Chrome/Safari */ | ||
| user-select: none; /* Firefox */ | ||
| user-select: none; /* IE10+ */ |
| --pst-font-family-base-system: -apple-system, blinkmacsystemfont, segoe ui, | ||
| "Helvetica Neue", arial, sans-serif, apple color emoji, segoe ui emoji, | ||
| segoe ui symbol; | ||
| --pst-font-family-monospace-system: "SFMono-Regular", menlo, consolas, monaco, | ||
| liberation mono, lucida console, monospace; |
There was a problem hiding this comment.
I think this will be OK, but I'm paranoid about preserving font name capitalization (legacy of many font-related LaTeX compilation errors). Is there an automated way we can we check this still works as designed?
Okay, see the note I wrote in #1823. |
|
Closing in favor of #1823. |
This PR adds the stylelint hook and a config file