Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for file src/pydata_sphinx_theme/locale/en/LC_MESSAGES/sphinx.po in fr #1801

Merged
merged 4 commits into from
May 20, 2024

Conversation

transifex-integration[bot]
Copy link
Contributor

@transifex-integration transifex-integration bot commented May 2, 2024

The following localization files have been updated:

Parameter Value
Source File src/pydata_sphinx_theme/locale/en/LC_MESSAGES/sphinx.po
Translation File src/pydata_sphinx_theme/locale/fr/LC_MESSAGES/sphinx.po
Language Code fr
Transifex Project pydata-sphinx-theme
Transifex Resource src..LC_MESSAGES/sphinx.po (main)
Transifex Event translated

100% translated source file: 'sphinx.po'
on 'fr'.
97% of minimum 100% translated source file: 'sphinx.po'
on 'fr'.
@@ -156,6 +156,10 @@ msgstr ""
"theme.readthedocs.io/en/stable/index.html\">Thème PyData Sphinx</a> "
"%(theme_version)s."

#: src/pydata_sphinx_theme/theme/pydata_sphinx_theme/sections/announcement.html:1
msgid "Announcement"
msgstr ""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that right ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must confess I don't fully understand what is the right way to translate this theme but this string was untranslated on Transifex and I just proceeded. So I guess the sphinx.po file should be updated sooner or later.

100% translated source file: 'sphinx.po'
on 'fr'.
Comment on lines +19 to +23
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"
"Generated-By: Babel 2.13.0\n"
"Language: fr\n"
"Plural-Forms: nplurals=3; plural=(n == 0 || n == 1) ? 0 : n != 0 && n % 1000000 == 0 ? 1 : 2;\n"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish I knew why transifex keeps introducing trivial changes like utf -> UTF or changing the order of these header/metadata lines. It makes these PRs much harder to assess.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can try to introduce a precomit-ci hook that normalise all those...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import polib
po = polib.pofile("sphinx.po")
po.metadata = {k: v for k, v in sorted(po.metadata.items())}
po.save("sphinx.po")

Should at least sort headers...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or see #1813

Carreau added a commit to Carreau/pydata-sphinx-theme that referenced this pull request May 16, 2024
See thread in pydata#1801 – automatic update from transifex-integration bot
have random changes in metadata content and order that are just noise.

With this the bot should do the PR and pre-commit-ci should hopefully
push a second commit that remove all churn in metadata.
@Carreau Carreau merged commit 48e4c01 into main May 20, 2024
1 of 3 checks passed
@Carreau Carreau deleted the translations_79592a50a377d7a120926189491c3d76_fr branch May 20, 2024 13:19
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

Carreau added a commit that referenced this pull request May 22, 2024
See thread in #1801 – automatic update from transifex-integration bot
have random changes in metadata content and order that are just noise.

With this the bot should do the PR and pre-commit-ci should hopefully
push a second commit that remove all churn in metadata.
ivanov pushed a commit to ivanov/pydata-sphinx-theme that referenced this pull request Jun 5, 2024
….po in fr (pydata#1801)

This update a few of the french translations in transifex.
---------

Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>
Co-authored-by: M Bussonnier <[email protected]>
ivanov pushed a commit to ivanov/pydata-sphinx-theme that referenced this pull request Jun 5, 2024
See thread in pydata#1801 – automatic update from transifex-integration bot
have random changes in metadata content and order that are just noise.

With this the bot should do the PR and pre-commit-ci should hopefully
push a second commit that remove all churn in metadata.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants