Remove shortcut hint in search field on mobile #1944
Milestone
Comments
|
I'm going to maybe go further and say that it's not necessary at all on the modal, as it is on the button ? |
Carreau
added a commit
to Carreau/pydata-sphinx-theme
that referenced
this issue
Aug 5, 2024
The shortcut is already present on the navbar button that will show the modal, thus it is likely unnecessary on the modal itself. As pointed out in pydata#1944, this is also super crowded on mobile, so less element is actually cleaner. This also remove Ctrl-K from the search field on the search page, but again, It is likely unnecessary there, as the user is already on the search page. In general I think removing is better than having it as an option as it is less maintenance. Closes pydata#1944
Carreau
added a commit
to Carreau/pydata-sphinx-theme
that referenced
this issue
Aug 5, 2024
The shortcut is already present on the navbar button that will show the modal, thus it is likely unnecessary on the modal itself. As pointed out in pydata#1944, this is also super crowded on mobile, so less element is actually cleaner. This also remove Ctrl-K from the search field on the search page, but again, It is likely unnecessary there, as the user is already on the search page. In general I think removing is better than having it as an option as it is less maintenance. Closes pydata#1944
|
I think it should be ok removing it as the modal is already enabled so the user should not need access to the shortcut anyway. |
|
I‘d prefer to keep the shortcut in the modal on large screens. See my comment in the PR. |
timhoffm
added a commit
to timhoffm/pydata-sphinx-theme
that referenced
this issue
Aug 6, 2024
Closes pydata#1944. Alternative to pydata#1945.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The search field contains the "Ctrl + K" shortcut hint. This is useful on keyboard PCs. IMHO it doesn't provide value on mobile. Additionally, the search field is smaller on mobile so that it's quite crowded. Would it be an option to remove the shortcut hint on mobile?
Search field with shortcut hint on mobile:
The text was updated successfully, but these errors were encountered: