Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes to RCTView props #234

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Various fixes to RCTView props #234

wants to merge 11 commits into from

Commits on Mar 18, 2019

  1. refactor: move "checkLayerExists:" to NSView+React

    And rename it to "ensureLayerExists"
    aleclarson committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    da36946 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    642fad3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    91f4cb2 View commit details
    Browse the repository at this point in the history
  4. fix: "transform" prop of RCTView

    We cannot set "layer.transform" directly except from the "displayLayer:" method, because AppKit often sets it without respecting explicit values. For example, the "setFrame:" method is one spot, but there are others.
    aleclarson committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    b3f6888 View commit details
    Browse the repository at this point in the history
  5. fix: add "transform" property to NSView

    This prevents a crash when a RCTViewManager represents a NSView subclass (instead of a RCTView subclass), which requires the subclass to implement its own "transform" property and override its "displayLayer:" method.
    aleclarson committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    2a2c404 View commit details
    Browse the repository at this point in the history
  6. fix: backfaceVisibility and shadow* props

    Ensure a layer exists before setting these props.
    aleclarson committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    c7a2bc3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a8c8218 View commit details
    Browse the repository at this point in the history
  8. fix: ensure layer exists in "reactSetFrame:"

    Otherwise, the anchor point won't be set.
    aleclarson committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    905b944 View commit details
    Browse the repository at this point in the history
  9. fix: set "position" and "anchorPoint" in "displayLayer:"

    Otherwise, the anchorPoint may be reverted to the top-left.
    aleclarson committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    fa28701 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2019

  1. fix: apply _transform in reactSetFrame

    The "setFrame:" method overrides our transform, so it needs to be reapplied.
    aleclarson committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    572a274 View commit details
    Browse the repository at this point in the history
  2. fix: RCTView setBackgroundColor

    - The "_backgroundColor" ivar was not being set when called with nil.
    
    - The method assumed that the "layer" property could be nullified when "backgroundColor" is nil, which is definitely not the case.
    aleclarson committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    33ac749 View commit details
    Browse the repository at this point in the history