-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes to RCTView props #234
base: master
Are you sure you want to change the base?
Commits on Mar 18, 2019
-
refactor: move "checkLayerExists:" to NSView+React
And rename it to "ensureLayerExists"
Configuration menu - View commit details
-
Copy full SHA for da36946 - Browse repository at this point
Copy the full SHA da36946View commit details -
Configuration menu - View commit details
-
Copy full SHA for 642fad3 - Browse repository at this point
Copy the full SHA 642fad3View commit details -
Enable edge antialiasing only for transforms with perspective
Taken from: facebook/react-native@cbf65f2
Configuration menu - View commit details
-
Copy full SHA for 91f4cb2 - Browse repository at this point
Copy the full SHA 91f4cb2View commit details -
fix: "transform" prop of RCTView
We cannot set "layer.transform" directly except from the "displayLayer:" method, because AppKit often sets it without respecting explicit values. For example, the "setFrame:" method is one spot, but there are others.
Configuration menu - View commit details
-
Copy full SHA for b3f6888 - Browse repository at this point
Copy the full SHA b3f6888View commit details -
fix: add "transform" property to NSView
This prevents a crash when a RCTViewManager represents a NSView subclass (instead of a RCTView subclass), which requires the subclass to implement its own "transform" property and override its "displayLayer:" method.
Configuration menu - View commit details
-
Copy full SHA for 2a2c404 - Browse repository at this point
Copy the full SHA 2a2c404View commit details -
fix: backfaceVisibility and shadow* props
Ensure a layer exists before setting these props.
Configuration menu - View commit details
-
Copy full SHA for c7a2bc3 - Browse repository at this point
Copy the full SHA c7a2bc3View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8c8218 - Browse repository at this point
Copy the full SHA a8c8218View commit details -
fix: ensure layer exists in "reactSetFrame:"
Otherwise, the anchor point won't be set.
Configuration menu - View commit details
-
Copy full SHA for 905b944 - Browse repository at this point
Copy the full SHA 905b944View commit details -
fix: set "position" and "anchorPoint" in "displayLayer:"
Otherwise, the anchorPoint may be reverted to the top-left.
Configuration menu - View commit details
-
Copy full SHA for fa28701 - Browse repository at this point
Copy the full SHA fa28701View commit details
Commits on Mar 19, 2019
-
fix: apply
_transform
in reactSetFrameThe "setFrame:" method overrides our transform, so it needs to be reapplied.
Configuration menu - View commit details
-
Copy full SHA for 572a274 - Browse repository at this point
Copy the full SHA 572a274View commit details -
fix: RCTView setBackgroundColor
- The "_backgroundColor" ivar was not being set when called with nil. - The method assumed that the "layer" property could be nullified when "backgroundColor" is nil, which is definitely not the case.
Configuration menu - View commit details
-
Copy full SHA for 33ac749 - Browse repository at this point
Copy the full SHA 33ac749View commit details