Various fixes to RCTView props #234
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And rename it to "ensureLayerExists"
We cannot set "layer.transform" directly except from the "displayLayer:" method, because AppKit often sets it without respecting explicit values. For example, the "setFrame:" method is one spot, but there are others.
This prevents a crash when a RCTViewManager represents a NSView subclass (instead of a RCTView subclass), which requires the subclass to implement its own "transform" property and override its "displayLayer:" method.
Ensure a layer exists before setting these props.
Otherwise, the anchor point won't be set.
Otherwise, the anchorPoint may be reverted to the top-left.
The "setFrame:" method overrides our transform, so it needs to be reapplied.
- The "_backgroundColor" ivar was not being set when called with nil. - The method assumed that the "layer" property could be nullified when "backgroundColor" is nil, which is definitely not the case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #232
[RCTViewManager checkLayerExists:]to[NSView ensureLayerExists]layermanually in[NSView ensureLayerExists](let thelayergetter call[NSView makeBackingLayer]instead)layer.transformdirectly except in[RCTView displayLayer:]ensureLayerExistsbefore setting any layer-related propensureLayerExistsinsidereactSetFrame:so layer props can be setpositionandanchorPointby setting them in[RCTView displayLayer:][RCTView setBackgroundColor:]strangeness