Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conformance-data/LinearGradient: it shouldn't disappear after navigation #2

Open
assynour opened this issue Aug 24, 2022 · 4 comments
Open

conformance-data/LinearGradient: it shouldn't disappear after navigation #2

assynour opened this issue Aug 24, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@assynour
Copy link
Contributor

assynour commented Aug 24, 2022 •
edited
Loading

The gradient should be updated after navigation and/or zooming.
@assynour
Copy link
Contributor Author

  • click on show conformance data button

  • activity SRM subprocess is filled with LinearGradient (function createLinearGradient in src/conformance.js)
    conformance-checking-linearGradient1

  • After navigating or zooming the diagram, the linearGradient disappears
    conformance-checking-linearGradient2

@assynour
Copy link
Contributor Author

After inspecting the html, I found that after navigation or zooming, the LinearGradient element is still there, but the fill property of the svg rect is reinitialized.

after navigation
svg-linearGradient1

@assynour
Copy link
Contributor Author

assynour commented Aug 25, 2022 •
edited
Loading

As a first solution, I tried to use the MutationObserver in index.js to observe changes and re-add the gradients each time a navigation or zooming is detected. I just added the code skeleton but didn't implement it yet.

@assynour assynour mentioned this issue Aug 25, 2022
Open
@tbouffard tbouffard self-assigned this Aug 25, 2022
@tbouffard tbouffard added the bug Something isn't working label Aug 25, 2022
@tbouffard tbouffard changed the title conformance-data/LinearGradient conformance-data/LinearGradient: it shouldn't disappear after navigation Aug 25, 2022
@tbouffard tbouffard mentioned this issue Oct 12, 2022
Closed
@tbouffard tbouffard added this to the Conference Ready milestone Oct 21, 2022
This was referenced Oct 23, 2022
Open
Open
Closed
@tbouffard tbouffard removed this from the ICPM 2022 Conference Ready milestone Oct 24, 2022
@tbouffard tbouffard mentioned this issue Oct 24, 2022
Open
tbouffard pushed a commit to tbouffard/pa-icpm-demo-2022 that referenced this issue Nov 8, 2022
@assynour
Merge pull request process-analytics#2 from assynour/refactor/simplif…
355d4cb 
…y_code

refactor: simplify the code
@assynour assynour mentioned this issue Mar 7, 2023
Open
@tbouffard
Copy link
Member

ℹ️ Same root cause as in #4 (comment)

@tbouffard tbouffard removed their assignment Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tbouffard @assynour