Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: compliance rules ripples circles are removed after applying a new CSS class #87

Open
assynour opened this issue Mar 7, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@assynour
Copy link
Contributor

assynour commented Mar 7, 2023

Describe the bug
In #85, the activities involved in compliance rules are highlighted on mouseover. When a new CSS class is added to highlight the activities, the ripple circles of the activity to be highlighted are discarded. Similar behavior as in #2 and #4.

To Reproduce
Steps to reproduce the behavior:

  1. Notice that Record Invoice Receipt has ripple circles
  2. Click on Clear Invoice
  3. Hover the mouse on Record Invoice Receipt in the displayed popover
  4. Notice that the ripple circles are discarded from Record Invoice Receipt

icpm-popover

@assynour assynour added the bug Something isn't working label Mar 7, 2023
@tbouffard
Copy link
Member

tbouffard commented Mar 7, 2023

This is the same root cause as in #4

  • the "ripple circles" are created by manually (i.e. without using the bpmn-visualization or mxGraph API) to modify the DOM
  • when applying a CSS class with the bpmn-visualization API, the SVG node are fully updated based on the content of the mxGraph model. The ripple circles are not stored in this model, so they are removed.

Something like what is described in #4 (comment) would fix the problem.

@tbouffard
Copy link
Member

tbouffard commented Mar 7, 2023

One workaround is to not apply a CSS class to the elements that contain the ripple circles.
This changes the scenario but this hides the problem.

@assynour
Copy link
Contributor Author

assynour commented Mar 7, 2023

A workaround is to no apply CSS class to elements that hold the ripple circles. This changes the scenario but this hides the problem.

I proposed another workaround for #85 in c8c6b3d. Not optimal but keeps the scenario as it is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants