Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] Remove the MutationObserver code #33

Closed
csouchet opened this issue Oct 11, 2022 · 1 comment · Fixed by #75
Closed

[REFACTOR] Remove the MutationObserver code #33

csouchet opened this issue Oct 11, 2022 · 1 comment · Fixed by #75
Assignees
@tbouffard
Milestone
ICPM 2022 Confere...

Comments

@csouchet
Copy link
Member

csouchet commented Oct 11, 2022 •
edited by tbouffard
Loading

Initial request: "add function to configure containerObserver"
@tbouffard
Copy link
Member

tbouffard commented Oct 12, 2022 •
edited
Loading

Can you provide more details in the description?
In my mind, we should remove the MutationObserver which is currently useless and was only an attempt to fix #2 and #24. It is not working at all, see #2 (comment)

https://github.com/assynour/icpm-demo-2022/blob/aef4e01609ccd557a5e8fd615fd4112889ae3e47/src/index.js#L38-L58

@tbouffard tbouffard changed the title (refactor) add function to configure containerObserver [REFACTOR] Remove the containerObserver code Oct 24, 2022
@tbouffard tbouffard added this to the ICPM 2022 Conference Ready milestone Oct 24, 2022
@tbouffard tbouffard self-assigned this Oct 24, 2022
@tbouffard tbouffard changed the title [REFACTOR] Remove the containerObserver code [REFACTOR] Remove the MutationObserver code Oct 24, 2022
@tbouffard tbouffard mentioned this issue Oct 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbouffard tbouffard

Labels
None yet
Projects
None yet
Milestone
ICPM 2022 Conference Ready
Development

Successfully merging a pull request may close this issue.

refactor: remove unused MutationObserver code process-analytics/icpm-demo-2022
2 participants
@csouchet @tbouffard