-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude Subnav links with aria-current set to "false" from active link styling #585
Conversation
🦋 Changeset detectedLatest commit: 9407fd3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🟢 No design token changes found |
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this @MelissaPastore 🙌
Changes look good to me 👍
Summary
List of notable changes:
Changes to SubNav styling:
packages/react/src/SubNav/SubNav.module.css
: Updated the CSS selectors for.SubNav__links-overlay--open .SubNav__link[aria-current]
,.SubNav__link:hover *
,.SubNav__link[aria-current]
and.SubNav__link[aria-current] .SubNav__link-label::after
to excludeSubNav
links witharia-current
set to "false" from active link styling. [1] [2] [3]Changes to SubNav stories:
packages/react/src/SubNav/SubNav.stories.tsx
: Updated aSubNav.Link
in theSubNav
story to havearia-current="false"
, to ensure changes in the CSS work as intended.Package version update:
.changeset/soft-chicken-march.md
: Bumped the patch version of@primer/react-brand
to reflect the changes made in this pull request.What should reviewers focus on?
Steps to test:
Supporting resources (related issues, external links, etc):
SubNav.Link
marked as current whenaria-current="false"
#572Contributor checklist:
Reviewer checklist:
Screenshots: