You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Version 0.32.0 of @primer/react-brand incorrectly marks SubNav.Link items as "current" when using aria-current="false". According to MDN, false is a valid value for this attribute.
Currently, the styling for SubNav.Link is activated by the mere presence of the aria-current attribute, rather than by its actual value.
Is there a need to set "false" here instead of undefined? Per MDN guidance, you only need to set the aria-current attribute for current items, it doesn't need to be set for others:
If the attribute is not present, is an empty string, is present with no value, or is set to aria-current="false" it is not exposed to the user.
While I can verify "false" is a valid value, I'm checking that this isn't blocking you right now?
Describe the bug
Version
0.32.0
of@primer/react-brand
incorrectly marksSubNav.Link
items as "current" when usingaria-current="false"
. According to MDN,false
is a valid value for this attribute.Currently, the styling for
SubNav.Link
is activated by the mere presence of thearia-current
attribute, rather than by its actual value.brand/packages/react/src/SubNav/SubNav.module.css
Lines 183 to 186 in eaeb50e
Reproduction steps
https://codepen.io/sergioalvz/pen/rNbrbae
Expected behavior
Only elements with
aria-current="page"
oraria-current="true"
are marked as currentScreenshots
No response
Browsers
No response
OS
No response
The text was updated successfully, but these errors were encountered: