Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeepIntent Bid Adapter: update docs with bid floor support #5616

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

caplock221b
Copy link

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 3bbca79
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/66fd6080f9034d0008ee36c6
😎 Deploy Preview https://deploy-preview-5616--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@atharvajangada
Copy link

Hi @muuki88 @lpagnypubstack @patmmccann
Could you please review this PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the floor module supported meta data as well as this is the most common way to set floor prices in prebid

@muuki88
Copy link
Contributor

muuki88 commented Sep 27, 2024

Please have a little patience as well. Prebid.js is heavily driven by a community of volunteers, which dedicate work and free time.

If you want things to go faster, join Prebid and help 😊💪 Pinging a reviewer is okay, but a bunch of people is a little too much 😉

@atharvajangada
Copy link

Hi @muuki88,
I apologise for tagging multiple maintainers at the same time. My PR for bid floor support in the main prebid repo was merged last Wednesday, so I thought that the docs PR also needs to be merged ASAP. Since this was my first contribution to prebid and open source in general, I was not aware of the correct process.

I have added the floors_supported metadata change as requested. Please review once again and let me know if any more changes are required.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants