DeepIntent Bid Adapter: add bid floor support

[caplock221b]

Type of change

• Bugfix

• Feature

• New bidder adapter

• Updated bidder adapter

• Code style update (formatting, local variables)

• Refactoring (no functional changes, no api changes)

• Build related changes

• CI related changes

• Does this change affect user-facing APIs or examples documented on http://prebid.org?

• Other

Description of change

• Added bidfloor field in impression of valid bid request
• Added a getFloor function to get the bid floor value from the request
• Added a test to check for passed bidfloor value
• Updated markdown example with optional bidfloor field

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/deepintentBidAdapter.js has 9 duplicated lines with modules/sovrnBidAdapter.js
• modules/deepintentBidAdapter.js has 14 duplicated lines with modules/sovrnBidAdapter.js
• modules/deepintentBidAdapter.js has 17 duplicated lines with modules/relevatehealthBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

[patmmccann]

Hi @caplock221b

It appears you have lots of duplicated code with sovrn and relevate health. Could you solve by importing it in common libraries?

Thanks!

[github-actions]

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

• libraries/deepintentUtils/index.js (+1 error)

[atharvajangada]

Hi @caplock221b

It appears you have lots of duplicated code with sovrn and relevate health. Could you solve by importing it in common libraries?

Thanks!

Hi @patmmccann
I have addressed your comment and moved the duplicate code to libraries folder.
All tests appear to be passing as well.
Can you re-review once and approve the PR?
Also can you review the related docs PR?

Thanks!

[patmmccann]

Nice work ty!