Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added temporaryStorage option to WASQLiteOpenFactory. #419

Merged
merged 5 commits into from
Nov 27, 2024

Conversation

Chriztiaan
Copy link
Contributor

@Chriztiaan Chriztiaan commented Nov 26, 2024

Overrides the default temp_store value for web to be memory. Additionally an option has been added to WebSQLOpenFactoryOptions to change this behaviour. This will change will affect all projects as the default has been file up until now for web projects.

Copy link

changeset-bot bot commented Nov 26, 2024

🦋 Changeset detected

Latest commit: 014138b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@powersync/web Minor
@powersync/diagnostics-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Chriztiaan Chriztiaan force-pushed the feat/wa-sqlite-tempstore branch from d058dc4 to bdc342d Compare November 26, 2024 10:02
@Chriztiaan Chriztiaan marked this pull request as ready for review November 26, 2024 10:15
stevensJourney
stevensJourney previously approved these changes Nov 26, 2024
Copy link
Collaborator

@stevensJourney stevensJourney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Chriztiaan Chriztiaan requested a review from rkistner November 26, 2024 11:48
@Chriztiaan Chriztiaan merged commit 36af0c8 into main Nov 27, 2024
6 checks passed
@Chriztiaan Chriztiaan deleted the feat/wa-sqlite-tempstore branch November 27, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants