Implemented minor PR feedback.

powersync-ja · Nov 26, 2024 · 014138b · 014138b
1 parent 9bac6b6
commit 014138b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/packages/web/src/db/adapters/wa-sqlite/WASQLiteDBAdapter.ts b/packages/web/src/db/adapters/wa-sqlite/WASQLiteDBAdapter.ts
@@ -107,8 +107,7 @@ export class WASQLiteDBAdapter extends BaseObserver<DBAdapterListener> implement
           : getWorkerDatabaseOpener(this.options.dbFilename, enableMultiTabs, optionsDbWorker);
 
       this.methods = await dbOpener(this.options.dbFilename);
-
-      await this.methods?.execute(tempStoreQuery);
+      await this.methods!.execute(tempStoreQuery);
       this.methods.registerOnTableChange(
         Comlink.proxy((event) => {
           this.iterateListeners((cb) => cb.tablesUpdated?.(event));
@@ -118,7 +117,7 @@ export class WASQLiteDBAdapter extends BaseObserver<DBAdapterListener> implement
       return;
     }
     this.methods = await _openDB(this.options.dbFilename, { useWebWorker: false });
-    await this.methods?.execute(tempStoreQuery);
+    await this.methods!.execute(tempStoreQuery);
     this.methods.registerOnTableChange((event) => {
       this.iterateListeners((cb) => cb.tablesUpdated?.(event));
     });

diff --git a/packages/web/src/db/adapters/web-sql-flags.ts b/packages/web/src/db/adapters/web-sql-flags.ts
@@ -43,8 +43,8 @@ export interface ResolvedWebSQLOpenOptions extends SQLOpenOptions {
 }
 
 export enum TemporaryStorageOption {
-  MEMORY = 'memory;',
-  FILESYSTEM = 'file;'
+  MEMORY = 'memory',
+  FILESYSTEM = 'file'
 }
 
 /**
@@ -63,6 +63,7 @@ export interface WebSQLOpenFactoryOptions extends SQLOpenOptions {
 
   /**
    * Where to store SQLite temporary files. Defaults to 'MEMORY'.
+   * Setting this to `FILESYSTEM` can cause issues with larger queries or datasets.
    */
   temporaryStorage?: TemporaryStorageOption;
 }