-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete non-ldv entries (extensive) #587
Open
jmuessel
wants to merge
14
commits into
pik-piam:master
Choose a base branch
from
jmuessel:delete-edgeT-plots
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
967c442
delete non-ldv plots and reportEDGETtransport.R
jmuessel 049ad5c
Merge branch 'master' of https://github.com/pik-piam/remind2 into del…
jmuessel e3bd943
deleted non-ldv entries
jmuessel 35af233
Merge branch 'master' of https://github.com/pik-piam/remind2 into del…
jmuessel df937bc
Update reportFE.R
jmuessel 78cb5ba
Merge branch 'master' of https://github.com/pik-piam/remind2 into del…
jmuessel 2bea964
Revert "Merge branch 'master' of https://github.com/pik-piam/remind2 …
jmuessel 47bcf7a
Reapply "Merge branch 'master' of https://github.com/pik-piam/remind2…
jmuessel 33b4f5c
delete non-ldv variables
jmuessel cbce5e4
Merge branch 'master' of https://github.com/pik-piam/remind2 into del…
jmuessel 4a9aa0d
Rename variables (Road|Electric --> Road|BEV by hand)
jmuessel 6015b13
intermediate push (buildLibrary did not finish)
jmuessel 4c94f4e
with bunkers
jmuessel 332c438
Update reportFE.R
jmuessel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orichters Due to deletion of 'fedie' , the function
addVar
throws the warning `In reportPrices, addVar called with a NA value, e.g. "Price|Final Energy|Transport|other|NA|Fossil (US$2005/GJ)".In consequence, duplicates are produced in the
out
object, and that is a problem.What would be the correct way to deal with this? Not delete the
fedie
entries or somehow address them being removed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orichters Btw, I think a warning in in addVar is not sufficient when there are NAs. Should crash or return NULL, as the returned magclass object becomes unusable, yet it is not easy to find the source of the problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consult with @Renato-Rodrigues who introduced the addVar function. I don't understand how this can create duplicates, though: this line should avoid it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, the duplicates are produced in another part of the code.
We still have to avoid the warning, @jmuessel as it will be thrown 50+ times, i.e. individual warnings are no longer printed and do not appear in the log.