Delete non-ldv entries (extensive) #587
Conversation
…ete-edgeT-plots
…ete-edgeT-plots
…ete-edgeT-plots
…into delete-edgeT-plots" This reverts commit 2bea964.
…ete-edgeT-plots
| @@ -342,7 +342,6 @@ reportPrices <- function(gdx, output=NULL, regionSubsetList=NULL, | |||
| fe = c( | |||
| fehos = "Liquids", | |||
| fepet = "LDV|Liquids", | |||
There was a problem hiding this comment.
@orichters Due to deletion of 'fedie' , the function addVar throws the warning `In reportPrices, addVar called with a NA value, e.g. "Price|Final Energy|Transport|other|NA|Fossil (US$2005/GJ)".
In consequence, duplicates are produced in the out object, and that is a problem.
What would be the correct way to deal with this? Not delete the fedie entries or somehow address them being removed?
There was a problem hiding this comment.
@orichters Btw, I think a warning in in addVar is not sufficient when there are NAs. Should crash or return NULL, as the returned magclass object becomes unusable, yet it is not easy to find the source of the problem.
There was a problem hiding this comment.
Please consult with @Renato-Rodrigues who introduced the addVar function. I don't understand how this can create duplicates, though: this line should avoid it.
There was a problem hiding this comment.
You are right, the duplicates are produced in another part of the code.
We still have to avoid the warning, @jmuessel as it will be thrown 50+ times, i.e. individual warnings are no longer printed and do not appear in the log.
In the new version, using reporttransport, non-ldv variables will not be reported anymore. With this PR
In another PR, I already renamed variables and deleted non-LDV variables from rmd skripts but not from the other R skripts as I am not sure about the consequences - see discussion below.
ToDos