Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require GID in Elasticsearch _id field #1364

Merged
merged 2 commits into from
Oct 4, 2019
Merged

Require GID in Elasticsearch _id field #1364

merged 2 commits into from
Oct 4, 2019

Commits on Oct 4, 2019

  1. feat(helper): add decode_gid helper 

    This is a low level helper to decode a GID, extracted from
`sanitizer/_ids`.
    @orangejulius
    orangejulius committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    b85288a View commit details
    Browse the repository at this point in the history

  2. feat(GID): Require GID to be stored in the _id field 

    This change implements the 5th and final step in the GID migration plan
outlined in
pelias/pelias#672 (comment).

It adjusts the expectations of the API so that it requires the
full GID, rather than the source_id, to be stored in the `_id` field in
Elasticsearch.

In the process, the `source_id` field is also no longer used in
`helper/geojsonify.js`, making this the first step towards removing the
`source_id` field (pelias/schema#383).

Connects pelias/pelias#672
    @orangejulius
    orangejulius committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    c867946 View commit details
    Browse the repository at this point in the history