Require GID in Elasticsearch _id field
#1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a low level helper to decode a GID, extracted from `sanitizer/_ids`.
This change implements the 5th and final step in the GID migration plan outlined in pelias/pelias#672 (comment). It adjusts the expectations of the API so that it requires the full GID, rather than the source_id, to be stored in the `_id` field in Elasticsearch. In the process, the `source_id` field is also no longer used in `helper/geojsonify.js`, making this the first step towards removing the `source_id` field (pelias/schema#383). Connects pelias/pelias#672
orangejulius
changed the title
_id field
orangejulius
added a commit
that referenced
this pull request
Nov 8, 2019
A breaking change was made in d1b3976 as part of #1363, but was missed in the release notes and version increment. This release is meant to draw attention to that breaking change. Any Pelias users looking to use pelias/api version 3.86.0 or later will need to ensure they use the API in combination with an Elasticsearch build run using compatible imports. As long as the importers are using a version released on September 13th, 2019 or later, there will be no compatibility issues. Here is the full list of compatible importer version numbers: * openaddresses: 2.37.0 * openstreetmap: 4.29.0 * whosonfirst: 2.44.1 * geonames: 2.32.2 * polylines: 1.12.2 * csv: 1.7.3 For full details on the breaking change, see the following issues and pull requests: * pelias/pelias#672 (comment) * #1363 * #1364 The following issue track the errors Pelias users will see if they are using incompatible versions of the API and importers: #1379. Our apologies for the confusion caused by anyone hit by this!
orangejulius
added a commit
that referenced
this pull request
Nov 8, 2019
BREAKING CHANGE: A breaking change was made in d1b3976 as part of #1363, but was missed in the release notes and version increment. This release is meant to draw attention to that breaking change. Any Pelias users looking to use pelias/api version 3.86.0 or later will need to ensure they use the API in combination with an Elasticsearch build run using compatible imports. As long as the importers are using a version released on September 13th, 2019 or later, there will be no compatibility issues. Here is the full list of compatible importer version numbers: * openaddresses: 2.37.0 * openstreetmap: 4.29.0 * whosonfirst: 2.44.1 * geonames: 2.32.2 * polylines: 1.12.2 * csv: 1.7.3 For full details on the breaking change, see the following issues and pull requests: * pelias/pelias#672 (comment) * #1363 * #1364 The following issue track the errors Pelias users will see if they are using incompatible versions of the API and importers: #1379. Our apologies for the confusion caused by anyone hit by this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements the 5th and final step in the GID migration plan outlined in pelias/pelias#672 (comment).
It adjusts the expectations of the API so that it requires the full GID, rather than the source_id, to be stored in the
_idfield in Elasticsearch.In the process, the
source_idfield is also no longer used inhelper/geojsonify.js, making this the first step towards removing thesource_idfield (pelias/schema#383).Closes pelias/pelias#672 🎉