Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PyPI upload #407

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Fix PyPI upload #407

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7dd0dca
fix upload/download artifact in CD.yml
dougiesquire Jan 22, 2024
e606ef8
Remove packages-dir from pypi publish
dougiesquire Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/CD.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,10 @@ jobs:
- run: |
python3 -m pip install --upgrade build && python3 -m build

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
path: ./dist
name: release
path: dist

pypi-publish:
# Split build and publish to restrict trusted publishing to just this workflow
Expand All @@ -36,14 +37,13 @@ jobs:
# IMPORTANT: this permission is mandatory for trusted publishing
id-token: write
steps:
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
path: artifact/
name: release
path: dist
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed these didn't match, but just assumed this was correct. I guess it wasn't?

Copy link
Collaborator Author

@dougiesquire dougiesquire Jan 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. The strange thing is that I haven't touched these...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best guess is it had to do with the version change of the pypi-publish action


- name: Publish package distributions to PyPI
uses: pypa/gh-action-pypi-publish@2f6f737ca5f74c637829c0f5c3acd0e29ea5e8bf # v1.8.11
with:
packages-dir: artifact/

conda:
name: Build with conda and upload
Expand Down
Loading